Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chrome opacity bug #1942

Merged
merged 2 commits into from
Jun 6, 2022
Merged

Fix chrome opacity bug #1942

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb2ebf5
Add webkit transform to force hardware accelerated transition
Jun 3, 2022
2bc2844
Change webkit-transform to general transform
Jun 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/js/components/shepherd-modal.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,7 @@
height: 100vh;
opacity: 0.5;
transition: all 0.3s ease-out, height 0s 0s, opacity 0.3s 0s;
-webkit-transform: translateZ(0);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
-webkit-transform: translateZ(0);
transform: translateZ(0);

@monshan I wonder if we can use just normal transform here? Not sure we need the webkit prefix anymore. Did you test this fix and it fixed the issue?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rwwagner90 yes when I did the dev build with this webkit prefix it worked for me, just tried the normal transform though and it also works. I'll re-commit shortly 👍

}

.shepherd-modal-overlay-container.shepherd-modal-is-visible path {
Expand Down