Add container property to step element #1075
Conversation
| @@ -260,7 +260,7 @@ export class Step extends Evented { | |||
| const labelId = `${this.id}-label`; | |||
|
|
|||
| this.shepherdElementComponent = new ShepherdElement({ | |||
| target: document.body, | |||
| target: this.tour.options.defaultStepOptions.elementContainer || document.body, | |||
There was a problem hiding this comment.
If this is a tour property, it should go on the tour. It will also need docs and tests.
There was a problem hiding this comment.
It will also need docs and tests.
@rwwagner90 can you give some intro guidance as to what you'd like to see here?
|
@nikitamadin do you believe you will have time to push this feature to completion? I'm looking for something similar. |
|
@shepmaster no, sorry |
|
@shepmaster would you have the time to open a new PR finishing this? I'm a little unclear on the use case and whether this should be a tour or step option. If it should be a step option, we shouldn't use |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@shepmaster thoughts on continuing this? |
|
Closed by #1176 |
Hello, it was necessary to place step elements inside the container, so I added the
elementContainerproperty