rework of the error handling #11
Conversation
jannik-hh
force-pushed
the
jg-rework-error-handling
branch
2 times, most recently
from
18f0fac to
ebe97fd
Compare
jannik-hh
force-pushed
the
jg-rework-error-handling
branch
3 times, most recently
from
2436b75 to
cfe04bc
Compare
jannik-hh
force-pushed
the
jg-rework-error-handling
branch
from
cfe04bc to
85f9526
Compare
|
|
||
| private | ||
|
|
||
| def self.error_class_for(response_code) |
There was a problem hiding this comment.
private (on line 24) does not make singleton methods private. Use private_class_method or private inside a class << self block instead.
|
Hi @sfroehler - any reason why this wasn't included in the 0.6.0 release? This was the most interesting part to us! |
|
Hi @bvogel It was not included because this is a breaking change and we needed a release with the remaining changes. |
|
😄 👍 |
jannik-hh
force-pushed
the
jg-rework-error-handling
branch
3 times, most recently
from
cc293e2 to
92ec495
Compare
|
ready to merge |
jannik-hh
force-pushed
the
jg-rework-error-handling
branch
from
92ec495 to
ff523a1
Compare
|
|
||
| Shipcloud::Request::Base.new(info).perform | ||
| expect { Shipcloud::Request::Base.new(info).perform }.to raise_error(Shipcloud::ShipcloudError) |
add more specific error classes access the entire response from the error object access the error descriptions directly from the error object
jannik-hh
force-pushed
the
jg-rework-error-handling
branch
from
ff523a1 to
7dfabd6
Compare
rework of the error handling
Added - Add the possibility to specify the api key on every request. (#8) - Add some more specific error classes ```Shipcloud::ClientError```,```Shipcloud::ServerError```, ```Shipcloud::InvalidRequestError```, ```Shipcloud::TooManyRequests``` and ```Shipcloud::NotFoundError``` (#11). - Access to the entire response and error descriptions from the error object (#11). Removed - Removed the following ruby versions from travis-ci test runs: - jruby-9.0.0.0 - Removed ```Shipcloud::APIError``` in preference to more granular error classes (#11).
|
Now I'm confused - as per SemVer I would have expected this to go into a mayor release (as it is breaking?) |
|
From semver.org:
As I mentioned before we did a separate release to make the remaining changes available without introducing a breaking change. |
|
Thanks for clearing that up - so when is v1.0.0 to be expected? :) |
add more specific error classes
access the entire response from the error object
access the error descriptions directly from the error object