Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

リノート解除時もとのノートを削除しないように #668

Merged

Conversation

4ster1sk
Copy link
Contributor

@4ster1sk 4ster1sk commented Nov 9, 2024

Fix: #646

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 71.42857% with 8 lines in your changes missing coverage. Please review.

Project coverage is 27.73%. Comparing base (6955662) to head (40b1caf).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
lib/view/note_modal_sheet/note_modal_sheet.dart 71.42% 8 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #668      +/-   ##
===========================================
+ Coverage    27.69%   27.73%   +0.03%     
===========================================
  Files          312      312              
  Lines        16253    16266      +13     
===========================================
+ Hits          4501     4511      +10     
- Misses       11752    11755       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shiosyakeyakini-info shiosyakeyakini-info merged commit 5c50a84 into shiosyakeyakini-info:develop Nov 10, 2024
1 check passed
@shiosyakeyakini-info
Copy link
Owner

🙇🙇🙇

@4ster1sk 4ster1sk deleted the fix/issue-646 branch November 10, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

リノートを解除しようとすると元のノート自体を削除してしまう
3 participants