Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageDialogの操作性改善 #557

Conversation

4ster1sk
Copy link
Contributor

・Dismissibleに変更しました
・画像の最大ズーム倍率を8倍まで拡大できるよう変更しました
・[デスクトップ]左右キーで画像の切り替えをできるようにしました

@4ster1sk
Copy link
Contributor Author

InteractiveViewerをフォークしたものに差し替えました。

Android、iOS以外でズームしていない場合に
onScaleStart,onScaleEnd,onScaleUpdateを呼ばないように変更しました。
(Windowsタブレットあたりでピンチズームが動かなくなったかも

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 650 lines in your changes are missing coverage. Please review.

Project coverage is 35.19%. Comparing base (bc44391) to head (9204058).

Files Patch % Lines
lib/view/common/interactive_viewer.dart 0.00% 517 Missing ⚠️
lib/view/common/image_dialog.dart 0.00% 133 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #557      +/-   ##
===========================================
- Coverage    36.61%   35.19%   -1.42%     
===========================================
  Files          257      258       +1     
  Lines        13586    14132     +546     
===========================================
  Hits          4974     4974              
- Misses        8612     9158     +546     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shiosyakeyakini-info shiosyakeyakini-info changed the base branch from develop to feature/miria_v2 June 22, 2024 05:17
@shiosyakeyakini-info shiosyakeyakini-info merged commit ccb591f into shiosyakeyakini-info:feature/miria_v2 Jun 22, 2024
@4ster1sk 4ster1sk deleted the fix/image-dialog branch July 14, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants