Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[デスクトップ] 初期ウィンドウサイズを縦長に変更する #538

Conversation

Npepperlinux
Copy link
Contributor

@Npepperlinux Npepperlinux commented Jan 22, 2024

起動時のウィンドウサイズが横に広い状態(Flutterのデフォルト)から、スマホのウィンドウに合わせて縦長にする提案です。

Conflict with #561 <- Resolved

  • Windows, Linuxでは1280x720から400x700に変更しました。
    • Windowsではウィンドウが画面中心に表示されるように変更しました。
  • macOSでは800x600から500x1000に変更しました。
    • この変更は未検証であるため、画面からはみ出す可能性があります。

※他に最適なサイズがある場合は提案をお願いします。

1920x1080な画面に400x700なウィンドウを表示させたときのサンプル
screenshot_240130004552

@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e0b4b79) 39.18% compared to head (4241f82) 37.67%.
Report is 196 commits behind head on develop.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #538      +/-   ##
===========================================
- Coverage    39.18%   37.67%   -1.51%     
===========================================
  Files          247      251       +4     
  Lines        11862    13342    +1480     
===========================================
+ Hits          4648     5027     +379     
- Misses        7214     8315    +1101     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shiosyakeyakini-info
Copy link
Owner

macもWindowsと一緒でいい気がする…(私自身が小さめのモニターをMacで使ってるので…

@Npepperlinux
Copy link
Contributor Author

macもWindowsと一緒でいい気がする…(私自身が小さめのモニターをMacで使ってるので…

Windowsと同じ値に設定しました。ただし、実際にどのような表示になるのかまでは確認していない(できない)ことに注意してください。

@shiosyakeyakini-info shiosyakeyakini-info changed the base branch from develop to feature/miria_v2 June 22, 2024 05:31
@shiosyakeyakini-info shiosyakeyakini-info merged commit 4f5d115 into shiosyakeyakini-info:feature/miria_v2 Jun 22, 2024
Npepperlinux added a commit to Npepperlinux/miria that referenced this pull request Jun 24, 2024
shiosyakeyakini-info added a commit that referenced this pull request Jul 14, 2024
@Npepperlinux Npepperlinux deleted the WindowSize branch October 22, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants