Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ユーザー画面でロールのアイコンを表示する #527

Merged

Conversation

poppingmoon
Copy link
Contributor

Misskey Webのロール表示に似せました

変更前
image

変更後
image

Fix #480

@codecov-commenter
Copy link

Codecov Report

Attention: 74 lines in your changes are missing coverage. Please review.

Comparison is base (d3aa4de) 39.00% compared to head (fcde9c7) 38.95%.

Files Patch % Lines
lib/view/explore_page/explore_role_users_page.dart 0.00% 36 Missing ⚠️
lib/extensions/string_extensions.dart 0.00% 26 Missing ⚠️
lib/view/user_page/user_detail.dart 63.33% 11 Missing ⚠️
lib/model/color_theme.dart 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #527      +/-   ##
===========================================
- Coverage    39.00%   38.95%   -0.06%     
===========================================
  Files          247      247              
  Lines        12112    12164      +52     
===========================================
+ Hits          4724     4738      +14     
- Misses        7388     7426      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shiosyakeyakini-info shiosyakeyakini-info merged commit f08e3e6 into shiosyakeyakini-info:develop Jan 21, 2024
1 check passed
@shiosyakeyakini-info
Copy link
Owner

マージしました!ありがとうございます!

@poppingmoon poppingmoon deleted the role-chip branch January 21, 2024 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ロールタイトルにカスタム絵文字が設定されていても表示されない
3 participants