Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

withRepliesとwithFilesを同時にtrueにしない #507

Conversation

poppingmoon
Copy link
Contributor

Fix #506

  • ユーザーのノート一覧で「返信つき」と「ファイルつき」のどちらかをタップしたときにもう一方の選択を解除するようにしました
  • タブ設定で「返信も入れる」と「ファイルのみにする」のどちらかをタップしたときにもう一方の選択を解除し、変更できなくするようにしました

@codecov-commenter
Copy link

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (d3aa4de) 39.00% compared to head (52dde7d) 39.00%.

Files Patch % Lines
...ings_page/tab_settings_page/tab_settings_page.dart 0.00% 8 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #507   +/-   ##
========================================
  Coverage    39.00%   39.00%           
========================================
  Files          247      247           
  Lines        12112    12120    +8     
========================================
+ Hits          4724     4728    +4     
- Misses        7388     7392    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shiosyakeyakini-info shiosyakeyakini-info merged commit caebcc5 into shiosyakeyakini-info:develop Jan 21, 2024
1 check passed
@poppingmoon poppingmoon deleted the avoid-both-with-replies-and-with-files branch January 21, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

withRepliesとwithFilesを両方にtrueにするとエラーが発生する
3 participants