Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageDialogでファイルをそのまま保存できるように #408

Conversation

poppingmoon
Copy link
Contributor

Fix #406

https://pub.dev/packages/image_gallery_saver#example の Saving file(ig: video/gif/others) from the internet を参考に、gifファイルなどもそのまま保存できるようにしました

これに伴って、ファイル名が必要なのでImageDialogにDriveFileを渡すようにしました

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2023

Codecov Report

Attention: 48 lines in your changes are missing coverage. Please review.

Comparison is base (07e6895) 37.56% compared to head (a1afc6c) 37.53%.

Files Patch % Lines
.../state_notifier/common/download_file_notifier.dart 0.00% 18 Missing ⚠️
lib/view/common/image_dialog.dart 0.00% 13 Missing ⚠️
...b/view/common/misskey_notes/misskey_file_view.dart 9.09% 10 Missing ⚠️
lib/view/misskey_page_page/misskey_page_page.dart 0.00% 5 Missing ⚠️
lib/providers.dart 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #408      +/-   ##
===========================================
- Coverage    37.56%   37.53%   -0.04%     
===========================================
  Files          251      252       +1     
  Lines        13282    13293      +11     
===========================================
  Hits          4990     4990              
- Misses        8292     8303      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poppingmoon poppingmoon force-pushed the image-dialog-save-file branch 2 times, most recently from 7aa6c82 to 69da27e Compare October 26, 2023 11:04
@poppingmoon poppingmoon force-pushed the image-dialog-save-file branch 2 times, most recently from 3d72375 to 2c7964b Compare November 5, 2023 05:44
@poppingmoon poppingmoon force-pushed the image-dialog-save-file branch 3 times, most recently from b6730f9 to f06c46c Compare November 26, 2023 23:26
@poppingmoon poppingmoon force-pushed the image-dialog-save-file branch from f06c46c to 6068ba7 Compare December 17, 2023 02:33
@poppingmoon poppingmoon force-pushed the image-dialog-save-file branch from 6068ba7 to 6490dc3 Compare January 21, 2024 06:51
@poppingmoon poppingmoon force-pushed the image-dialog-save-file branch from 6490dc3 to a1afc6c Compare January 28, 2024 00:27
@shiosyakeyakini-info shiosyakeyakini-info changed the base branch from develop to feature/miria_v2 June 22, 2024 05:19
@shiosyakeyakini-info shiosyakeyakini-info merged commit d070fc6 into shiosyakeyakini-info:feature/miria_v2 Jul 14, 2024
@shiosyakeyakini-info
Copy link
Owner

🙏🙏

@poppingmoon poppingmoon deleted the image-dialog-save-file branch July 14, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

画像をオリジナルのまま保存できるようにする
3 participants