システムのデフォルトフォントの指定の整理（KosugiMaruの完全削除を含む） #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #318 +/- ##
===========================================
- Coverage 36.60% 36.60% -0.01%
===========================================
Files 257 257
Lines 13587 13596 +9
===========================================
+ Hits 4974 4977 +3
- Misses 8613 8619 +6 ☔ View full report in Codecov by Sentry. |
Npepperlinux
force-pushed
the
fonts_fix
branch
3 times, most recently
from
3972968 to
fe24e07
Compare
Merged
Npepperlinux
force-pushed
the
fonts_fix
branch
from
fe24e07 to
223b693
Compare
Npepperlinux
changed the title
|
|
fontFamilyが指定されていなくてfontFamilyFallbackが指定されているときはfontFamilyFallbackの最初のフォントがfontFamilyとして扱われるみたいなのでfontFamilyFallbackだけ指定するようにすればもう少しシンプルになるんじゃないかと思います https://api.flutter.dev/flutter/painting/TextStyle/fontFamilyFallback.html |
|
dead codeがあります vscodeであれば拡張機能を入れることでエラーや警告がわかりやすくなります |
Npepperlinux
changed the title
|
CJKは限定的にNoto Sansの指定を言語ごとに切り替えたほうがいいかもしれない |
shiosyakeyakini-info
merged commit 303c695
into
shiosyakeyakini-info:feature/miria_v2
1 check failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
現在、WindowsではBIZ UDPゴシック（Noto Sans CJK JPを読み込んでいない、
KosugiMaruは #281 待ちClose）、Androidでは指定なし（同じくKosugiMaruが #281 待ち）Closeの状態になっています。国際化対応(#164)や
google_fontsの設定をするまでの間の設定として、Windows、AndroidでNoto Sans CJK JPを使用するように固定する提案です。Close #489