Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextScaleFactorの変更時にボタンを押すまで反映されないように #317

Conversation

poppingmoon
Copy link
Contributor

@poppingmoon poppingmoon commented Sep 15, 2023

全般設定でフォントサイズを変更したときに、変更ボタンを押すまで表示されるフォントサイズを変更しないようにしました
ただし、フォントサイズ以外の項目を変更したとき、フォントサイズの変更が適用されていない場合でも同時に適用されます

また、ElevatedButtonのonPressedがnullのときにボタンの見た目がほとんど変わらなかったのを、disabledであることがわかるように変更しました

@poppingmoon poppingmoon force-pushed the change-text-scale-factor-on-pressed branch from de3fea4 to 3ccfac1 Compare November 19, 2023 22:03
@codecov-commenter
Copy link

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (d7d9ac2) 39.72% compared to head (3ccfac1) 39.69%.

Files Patch % Lines
...e/general_settings_page/general_settings_page.dart 0.00% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #317      +/-   ##
===========================================
- Coverage    39.72%   39.69%   -0.03%     
===========================================
  Files          237      237              
  Lines        11681    11683       +2     
===========================================
- Hits          4640     4638       -2     
- Misses        7041     7045       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shiosyakeyakini-info shiosyakeyakini-info changed the base branch from develop to feature/miria_v2 June 22, 2024 05:32
@shiosyakeyakini-info shiosyakeyakini-info merged commit 541d3c3 into shiosyakeyakini-info:feature/miria_v2 Jun 22, 2024
@poppingmoon poppingmoon deleted the change-text-scale-factor-on-pressed branch June 22, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants