Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

アカウントを並び替えられるように #282

Merged

Conversation

poppingmoon
Copy link
Contributor

@poppingmoon poppingmoon commented Aug 31, 2023

アカウント設定画面でアカウントを並べ替えられるようにしました

  • ドラッグすることで順番を変えられます
  • iOSやAndroidでもハンドルが表示されるようにしました
    • ドラッグできることを示すための飾りとして
    • タブ設定画面も同様に変更しました
  • 削除はボタンをタップするとダイアログが出るようにしました

これに伴ってAccountRepositoryを書き換えました

  • iを更新したアカウントをSetで保持するようにしました
  • アカウントを追加する際に既に追加されているアカウントを追加できないようにしました
  • 1つ目のアカウントが追加されたときに追加するタブ設定をTabSettingsRepositoryに移しました

Fix #238
Fix #239
Fix #48

@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2023

Codecov Report

Merging #282 (767ae6f) into develop (e88295f) will decrease coverage by 0.10%.
The diff coverage is 12.09%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##           develop     #282      +/-   ##
===========================================
- Coverage    40.18%   40.08%   -0.10%     
===========================================
  Files          235      235              
  Lines        11423    11448      +25     
===========================================
- Hits          4590     4589       -1     
- Misses        6833     6859      +26     
Files Coverage Δ
lib/providers.dart 88.67% <100.00%> (+0.14%) ⬆️
lib/view/common/sharing_intent_listener.dart 64.00% <100.00%> (ø)
lib/repository/import_export_repository.dart 0.00% <0.00%> (ø)
lib/view/common/main_stream.dart 0.00% <0.00%> (ø)
lib/view/login_page/api_key_login.dart 2.32% <0.00%> (ø)
lib/view/login_page/password_login.dart 0.00% <0.00%> (ø)
...iew/settings_page/app_info_page/app_info_page.dart 3.70% <0.00%> (ø)
lib/view/time_line_page/time_line_page.dart 52.83% <87.50%> (-0.28%) ⬇️
...iew/common/misskey_notes/open_another_account.dart 10.34% <0.00%> (ø)
...ings_page/tab_settings_page/tab_settings_page.dart 0.00% <0.00%> (ø)
... and 9 more

... and 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@poppingmoon poppingmoon force-pushed the account-settings branch 2 times, most recently from 3468152 to c47fa0d Compare October 2, 2023 11:54
@poppingmoon poppingmoon force-pushed the account-settings branch 2 times, most recently from 99ba5a9 to 3a2875b Compare October 15, 2023 23:09
@poppingmoon poppingmoon force-pushed the account-settings branch 3 times, most recently from 3cfc861 to 61f0fc6 Compare October 19, 2023 22:02
@poppingmoon poppingmoon force-pushed the account-settings branch 4 times, most recently from 1cd884d to 5ff6704 Compare November 4, 2023 10:01
@shiosyakeyakini-info shiosyakeyakini-info merged commit 02a67d6 into shiosyakeyakini-info:develop Nov 23, 2023
1 check passed
@poppingmoon poppingmoon deleted the account-settings branch November 23, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants