Fix enqueue! typespec #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, sorry, didn't notice the PR until now. Good spot but I guess we need to remove https://github.com/shinyscorpion/task_bunny/blob/master/lib/task_bunny/job.ex#L199 Would you mind update the PR? Or I will do it sometime soon. |
It seems that dialyzer is not checking this typespec. Its probably
related to macros but I'm not entirely sure. `TaskBunny.Job.enqueue!`
spec clearly says that only return value is :ok.
This was discovered when using this library in an application:
```
lib/transporter/delivery_requests/delivery_job.ex:5: The specification
for 'Elixir.Transporter.DeliveryRequests.DeliveryJob':'enqueue!'/2
states that the function might also return {'error',_} but the
inferred return is 'ok'
```
|
updated |
|
Awesome. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that dialyzer is not checking this typespec. Its probably
related to macros but I'm not entirely sure.
TaskBunny.Job.enqueue!spec clearly says that only return value is :ok.
This was discovered when using this library in an application: