Attempt to fix issue #858 #859
Conversation
|
oh even with a test case, great! I'll just give a look into a graphite setup, and should be ok for 1.4, (just in time :) ). |
|
|
||
| name = self.illegal_char.sub('_', elts[0]) | ||
| name = self.illegal_char.sub('_', e.name) |
There was a problem hiding this comment.
What is the perfdata is malformed? (like iwth no = ) name will be None isn't it?
There was a problem hiding this comment.
In a previous version I added a test case to cover perfdata with equal sign but no value and the perfdata is simply ignored because it doesn't match the second regular expression. I didn't test when there is no equal sign.
I will test it on monday if possible, and include more unittests to cover these corner cases.
There was a problem hiding this comment.
About replacing all non word characters by underscores: it would be great if we could allow more characters, because Graphite allows more characters than that.
I tried to dig in Graphite's code to find the exact list of allowed characters, but to no avail. In fact Carbon can use a lot of characters on Unix, only / and null are forbidden, but currently graphite-web can't handle parenthesis, UTF-8, etc.
I think that until we have a clear view on what's allowed on Graphite's side, we have to stick to the current behavior.
You'll find some info in this issue: graphite-project/graphite-web#242
|
Thanks it's merged :) I try with a very bad format name, and the only errors were about unicode (that are now catched). Which name can I put into the THANKS file? :) |
|
Hello My name is: Alexandre Veyrenc |
|
Welcome on the THANKS file so :) (and in the 1.4 changelog ;) ) On Mon, May 27, 2013 at 9:23 AM, Jean-Claude Computing <
|
Hello
Here is an attempt to fix issue #858. It works with perfdata containing spaces and optionally surrounded by single quotes.
It does not handle range format for warn and crit.
Tested on our production system with Shinken sending perfdata to Graphite. Maybe the same problem exists with PNP4Nagios, but since we don't use it, I didn't have the opportunity to check it.