Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi shimberger:
maybe we can persistent log for later debuging. so I use
gopkg.in/natefinch/lumberjack.v2
to persistent logfile, default islogs/server.log
and the log format change a bit
logformat before:
logformat now:
in
internal/logger/logger.go
, we config the log setttings ininit()
method, and ininternal/cmd/serve.go
, we import_ "github.com/shimberger/gohls/internal/logger"
makeinit()
called, so in the whole project, when we uselogrus
print info, the setting oflogrus
will be applied