fix(core): createdBundledHighlighter
cause wasm engine to be loaded
#819
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While playing with JavaScript Regex engine and
getSingletonHighlighter
, I noticed that the WASM engine was loaded regardless of myengine
option, and it is indeed using the JavaScript engine.After looking into the codebase, I found:
In the code of
createdBundledHighlighter
(highlighter factory), this causesengine
to be called and hence the WASM engine is loaded with lazy import, even if it is unused.Linked Issues
N/A
Additional context