Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update Slidev & Nuxt links #817

Merged
merged 2 commits into from
Oct 25, 2024
Merged

docs: update Slidev & Nuxt links #817

merged 2 commits into from
Oct 25, 2024

Conversation

Beraliv
Copy link
Contributor

@Beraliv Beraliv commented Oct 24, 2024

Description

Update the links to integrations from from https://shiki.style/packages/twoslash#integrations:

  • Updated the link to Slidev integration
  • Updated the link to Nuxt integration

Linked Issues

None

Additional context

When I was at https://shiki.style/packages/twoslash#integrations

  1. The Slidev link pointed to the 404 page. The TwoSlash Integration has been moved to https://sli.dev/features/twoslash#twoslash-integration therefore updating it in docs.

  2. The Nuxt link pointed to non-existing hash (i.e. #twoslash) while the correct one was #twoslash-integration

Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for shiki-matsu ready!

Name Link
🔨 Latest commit 0e3c78e
🔍 Latest deploy log https://app.netlify.com/sites/shiki-matsu/deploys/671aa6468c321c0008f1d718
😎 Deploy Preview https://deploy-preview-817--shiki-matsu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for shiki-next ready!

Name Link
🔨 Latest commit 0e3c78e
🔍 Latest deploy log https://app.netlify.com/sites/shiki-next/deploys/671aa646c745510008aaf401
😎 Deploy Preview https://deploy-preview-817--shiki-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Beraliv Beraliv marked this pull request as ready for review October 24, 2024 19:53
docs/packages/twoslash.md Outdated Show resolved Hide resolved
Update docs/packages/twoslash.md
@Beraliv Beraliv changed the title docs: update Slidev link docs: update Slidev & Nuxt links Oct 24, 2024
@antfu antfu merged commit 162a23f into shikijs:main Oct 25, 2024
11 checks passed
@Beraliv Beraliv deleted the patch-1 branch November 17, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants