-
-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return the grammar state after tokenizing #715
Comments
What would be the API looks like in your mind? |
Including the GrammarState in the TokensResult would be ideal. Sample usageclass EditorTokensProvider {
// ...
tokenizeLine(line, state?: GrammarState) {
const {tokens, grammarState} = highligher.codeToTokens(code, {theme, grammarState: state, lang))
return {tokens: tokens[0], endState: grammarState }
}
//...
} Additionally, could you provide a default static method in the GrammarState to get an initial state? class GrammarState
{
static default(lang, theme)
{
return new GrammarState(INITIAL, lang, theme)
}
} Thank you for this awesome project and for your time! |
That would be a breaking change to the function unfortunately. We would need to find another non-breaking API for that |
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [shiki](https://togithub.com/shikijs/shiki) ([source](https://togithub.com/shikijs/shiki/tree/HEAD/packages/shiki)) | [`1.10.3` -> `1.12.1`](https://renovatebot.com/diffs/npm/shiki/1.10.3/1.12.1) | [![age](https://developer.mend.io/api/mc/badges/age/npm/shiki/1.12.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/shiki/1.12.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/shiki/1.10.3/1.12.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/shiki/1.10.3/1.12.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>shikijs/shiki (shiki)</summary> ### [`v1.12.1`](https://togithub.com/shikijs/shiki/releases/tag/v1.12.1) [Compare Source](https://togithub.com/shikijs/shiki/compare/v1.12.0...v1.12.1) ##### 🚀 Features - New `dotenv` grammar, new `everforest` theme - by [@​antfu](https://togithub.com/antfu) [<samp>(29b1d)</samp>](https://togithub.com/shikijs/shiki/commit/29b1d3aa) ##### [View changes on GitHub](https://togithub.com/shikijs/shiki/compare/v1.12.0...v1.12.1) ### [`v1.12.0`](https://togithub.com/shikijs/shiki/releases/tag/v1.12.0) [Compare Source](https://togithub.com/shikijs/shiki/compare/v1.11.2...v1.12.0) ##### 🚀 Features - Add static `initial` method for `GrammarState`, [#​715](https://togithub.com/shikijs/shiki/issues/715) - by [@​antfu](https://togithub.com/antfu) in [https://github.com/shikijs/shiki/issues/715](https://togithub.com/shikijs/shiki/issues/715) [<samp>(be07d)</samp>](https://togithub.com/shikijs/shiki/commit/be07da89) - New `ts-tags` grammar, lit support, close [#​725](https://togithub.com/shikijs/shiki/issues/725) - by [@​antfu](https://togithub.com/antfu) in [https://github.com/shikijs/shiki/issues/725](https://togithub.com/shikijs/shiki/issues/725) [<samp>(3107a)</samp>](https://togithub.com/shikijs/shiki/commit/3107a2d0) ##### 🐞 Bug Fixes - **core**: Fix decoration offset edge cases - by [@​timothycohen](https://togithub.com/timothycohen) in [https://github.com/shikijs/shiki/issues/728](https://togithub.com/shikijs/shiki/issues/728) [<samp>(1349b)</samp>](https://togithub.com/shikijs/shiki/commit/1349bb4d) ##### [View changes on GitHub](https://togithub.com/shikijs/shiki/compare/v1.11.2...v1.12.0) ### [`v1.11.2`](https://togithub.com/shikijs/shiki/releases/tag/v1.11.2) [Compare Source](https://togithub.com/shikijs/shiki/compare/v1.11.1...v1.11.2) ##### 🐞 Bug Fixes - **core**: Fix the incorrect parameter when using a single theme - by [@​il-1337](https://togithub.com/il-1337) in [https://github.com/shikijs/shiki/issues/723](https://togithub.com/shikijs/shiki/issues/723) [<samp>(5e2a6)</samp>](https://togithub.com/shikijs/shiki/commit/5e2a69e2) - **rehype**: Add the misssing `CodeToHastOptionsCommon` to `RehypeShikiCoreOptions` for `rehype` plugin - by [@​fwqaaq](https://togithub.com/fwqaaq) in [https://github.com/shikijs/shiki/issues/726](https://togithub.com/shikijs/shiki/issues/726) [<samp>(c8c14)</samp>](https://togithub.com/shikijs/shiki/commit/c8c1468d) ##### [View changes on GitHub](https://togithub.com/shikijs/shiki/compare/v1.11.1...v1.11.2) ### [`v1.11.1`](https://togithub.com/shikijs/shiki/releases/tag/v1.11.1) [Compare Source](https://togithub.com/shikijs/shiki/compare/v1.11.0...v1.11.1) ##### 🐞 Bug Fixes - CodeToTokens's includeExplanation option - by [@​uxiew](https://togithub.com/uxiew) in [https://github.com/shikijs/shiki/issues/718](https://togithub.com/shikijs/shiki/issues/718) [<samp>(55e85)</samp>](https://togithub.com/shikijs/shiki/commit/55e857b8) - **vitepress-twoslash**: Correct client types - by [@​sxzz](https://togithub.com/sxzz) in [https://github.com/shikijs/shiki/issues/720](https://togithub.com/shikijs/shiki/issues/720) [<samp>(c8f30)</samp>](https://togithub.com/shikijs/shiki/commit/c8f301c9) ##### [View changes on GitHub](https://togithub.com/shikijs/shiki/compare/v1.11.0...v1.11.1) ### [`v1.11.0`](https://togithub.com/shikijs/shiki/releases/tag/v1.11.0) [Compare Source](https://togithub.com/shikijs/shiki/compare/v1.10.3...v1.11.0) ##### 🚀 Features - Update grammar and themes - by [@​antfu](https://togithub.com/antfu) [<samp>(91c7f)</samp>](https://togithub.com/shikijs/shiki/commit/91c7f016) ##### [View changes on GitHub](https://togithub.com/shikijs/shiki/compare/v1.10.3...v1.11.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [x] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/ariakit/ariakit). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xOC4xNyIsInVwZGF0ZWRJblZlciI6IjM4LjE4LjE3IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Clear and concise description of the problem
codeToTokens
to return the grammar state after tokenization.Suggested solution
This could be beneficial for tokenization in the editor I'm currently developing
Alternative
No response
Additional context
No response
Validations
Contributes
The text was updated successfully, but these errors were encountered: