Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve regex #117

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat: improve regex #117

wants to merge 4 commits into from

Conversation

victorbiga
Copy link

No description provided.

@victorbiga victorbiga changed the title feat: trigger feat: improve regex Aug 10, 2023
@griseau
Copy link

griseau commented Aug 16, 2023

@shift any chance you could review it ? It would help us not to maintain a fork 🙈

@victorbiga
Copy link
Author

@shift not sure why the build failed, does not seem to this PR related. Any chance to have a look pls ?

@burnjake
Copy link
Contributor

@shift Opened a PR to fix the version issues, would be great for a review please 🙏 #118

@victorbiga
Copy link
Author

victorbiga commented Sep 4, 2023 •
edited
Loading

@shift #118 now merged, would need approval to run GH Actions once again on this PR to fix missing regex on some domains.

@adamdecaf
Copy link
Collaborator

Do you have a testable response to add which verifies this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@victorbiga @griseau @burnjake @adamdecaf