Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add action for updating pypi package #57

Merged
merged 2 commits into from
Jun 27, 2022
Merged

Add action for updating pypi package #57

merged 2 commits into from
Jun 27, 2022

Conversation

zimmerrol
Copy link
Collaborator

@zimmerrol zimmerrol commented Jun 23, 2022 •
edited
Loading

  • Add action for updating pypi package whenever a new release ia created
  • Modifications for making the package pass twine's checks

@zimmerrol zimmerrol requested a review from stes June 23, 2022 21:28
stes
stes approved these changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@stes stes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, although I would wait with the first release until

gets resolved.

setup.cfg
@@ -35,7 +35,7 @@ project_urls =
classifiers =
Programming Language :: Python :: 3
Intended Audience :: Developers
License :: OSI Approved :: Apache License 2.0
License :: OSI Approved :: Apache Software License
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the classifier, we should update it as soon as pypa/trove-classifiers#17 gets merged.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good point.

@zimmerrol zimmerrol merged commit 03e4a66 into shift-happens-benchmark:main Jun 27, 2022
@zimmerrol zimmerrol deleted the pypi branch June 27, 2022 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stes stes stes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
First release for ShiftHappens ICML 2...
Development

Successfully merging this pull request may close these issues.
2 participants
@zimmerrol @stes