Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created a new section for Signedness #643

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Conversation

ZRX-SIGMA
Copy link
Contributor

@ZRX-SIGMA ZRX-SIGMA commented Oct 1, 2023

Proposed changes

Created a new section for Signedness under DataTypes
Edited, as some of the datatype sizes were wrong and ambiguous

Types of changes

What types of changes does your content introduce to this project?
Put an x in the boxes that apply (without "`")

  • Proofreading (fix spelling, grammar, punctuation, accuracy) Proofreading
  • New content (new section, new readme, etc.)
  • Modifications (modifying existing content)
  • Other (please describe)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. Don't hesitate to ask if you're unsure about any of them. We're here to help! This simply reminds us of what we will look for before merging your code.
Note: If you submit code make sure to test it

  • Tested any code that was added/modified in this PR
  • Added external links
  • Added internal links
  • Added images
  • Added videos
  • Added code snippets

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Adding your name to the contributor's list

Comment "@all-contributors please add @your_username for content" to add your name to the contributor's list.
You can change the "content" with any of this

Reviewers:

  • @username

Please ensure that you are not adding any sensitive information like API keys, secrets, passwords, tokens, usernames, or other credentials. Refrain from adding your name, email, or other personal information.

@the-label-bot the-label-bot bot added kind/documentation kind/documentation size/M size/M labels Oct 1, 2023
@the-label-bot
Copy link

the-label-bot bot commented Oct 1, 2023

The Label Bot has predicted the following:

Category Value Confidence Applied Label
Kind documentation 0.989 ✔️
Kind M 0.984 ✔️

@ZRX-SIGMA
Copy link
Contributor Author

ZRX-SIGMA commented Oct 1, 2023

@shhossain Can u please help in this, dont know why it failed the test , when I have mostly added and edited Text, and entered 2 codes(C lang) .

@shhossain
Copy link
Owner

@ZRX-SIGMA, this is not your concern. The code was committed before creating test.py. I will review your content as soon as possible.

@ZRX-SIGMA
Copy link
Contributor Author

@ZRX-SIGMA, this is not your concern. The code was committed before creating test.py. I will review your content as soon as possible.

ok thanks

@ZRX-SIGMA
Copy link
Contributor Author

@shhossain It will be helpful if you could add this in hacktoberfest-accepted ..

@shhossain shhossain merged commit aa34566 into shhossain:main Oct 3, 2023
1 check failed
@shhossain
Copy link
Owner

@all-contributors add @ZRX-SIGMA for content

@allcontributors
Copy link
Contributor

@shhossain

I've put up a pull request to add @ZRX-SIGMA! 🎉

@shhossain shhossain added the hacktoberfest-accepted hacktoberfest-accepted label Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted hacktoberfest-accepted kind/documentation kind/documentation size/M size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants