Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of C++ from Longest Common Subsequence #554

Merged
merged 2 commits into from
Oct 29, 2022

Conversation

jhuynh06
Copy link
Contributor

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. Your PR title can be also used in here.

Types of changes

What types of changes does your content introduce to this project?
Put an x in the boxes that apply (without "`")

  • Proofreading (fix spelling, grammar, punctuation, accuracy) Proofreading
  • New content (new section, new readme, etc)
  • Modifications (modifying existing content, adding new content)
  • Other (please describe)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. Don't hesitate to ask if you're unsure about any of them. We're here to help! This is simply a reminder of what we will look for before merging your code.
Note: If you submit code make sure to test it

  • Tested any code that was added/modified in this PR
  • Added the necessary explanation
  • I have added the necessary links in the working section
  • Added external links
  • Added internal links
  • Added images
  • Added videos
  • Added code snippets

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Adding your name in the contributors list

Comment "@all-contributors please add @your_username for content" to add your name in the contributors list.
You can change the "content" with any of this

Reviewers:

  • @username

If you adding code, please make sure that you are not adding any sensitive information like API keys, secrets, passwords, tokens, usernames, or other credentials. Refrain from adding your name, email, or other personal information to the code.

@the-label-bot the-label-bot bot added the kind/documentation kind/documentation label Oct 29, 2022
@the-label-bot
Copy link

the-label-bot bot commented Oct 29, 2022

The Label Bot has predicted the following:

Category Value Confidence Applied Label
Kind documentation 0.836 ✔️
Size S 0.989 ✔️

@the-label-bot the-label-bot bot added the size/M size/M label Oct 29, 2022
@the-label-bot the-label-bot bot added size/S size/S and removed size/M size/M labels Oct 29, 2022
Copy link
Owner

@shhossain shhossain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging.

@shhossain shhossain merged commit 2ac9ef0 into shhossain:main Oct 29, 2022
@shhossain
Copy link
Owner

@all-contributors please add @jhuynh06 for bug, test.

@allcontributors
Copy link
Contributor

@shhossain

I've put up a pull request to add @jhuynh06! 🎉

@shhossain shhossain linked an issue Oct 31, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation kind/documentation size/S size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove broken code in readme files. (python, cpp, c#, java, etc)
2 participants