-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup PostgreSQL #9
Conversation
@@ -21,6 +21,7 @@ | |||
|
|||
|
|||
# SECURITY WARNING: don't run with debug turned on in production! | |||
SECRET_KEY = 'dulwepf_b#@eh19w)==v+pxvw$u$2gbxpwoevmzg)h-pl1mded' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kellim was right, it doesn't run without the secret key.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmhm, ok. We should still not have have the secret_key on Github, but ideally in an env variable. Same for the database details below.
Would you be comfortable setting that up, @nurmerey, or would you prefer I do that?
Considering this is only for local development at this point, I'm fine keeping it for now such that you are able to move on. I'd create a story to switch the project over to use environment variables though, before we deploy it.
Let me know what you prefer, @nurmerey? 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@natsteinmetz Would python-dotenv be acceptable for using in development? https://preslav.me/2019/01/09/dotenv-files-python/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@natsteinmetz I have created a separate story for the secret key and db details - #14
PR for issue #2
Note: to run and test this locally, you need to do the following parts of the above tutorial:
pip install psycopg2
, then trysudo installer -pkg /Library/Developer/CommandLineTools/Packages/macOS_SDK_headers_for_macOS_10.14.pkg -target /
python manage.py migrate