This repository has been archived by the owner on Nov 6, 2024. It is now read-only.
Update [email protected] and [email protected] #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we have this Yarn bug on the App Veyor image : yarnpkg/yarn#3313 |
|
Not related to the bug you linked. I reinstalled the same yarn version as AppVeyor and running |
scote
previously approved these changes
Sep 26, 2017
scote
suggested changes
Sep 27, 2017
| }); | ||
| }); | ||
|
|
||
| describe('collapsible link', () => { |
There was a problem hiding this comment.
Why do we remove those unit tests?
There was a problem hiding this comment.
The test was meant to be sure that fixCloseOnClick won't close the menu on mobile when clicking on a item that should collapse (not a page link)
scote
approved these changes
Sep 27, 2017
GulajavaMinistudio
added a commit
to TypescriptID/ng2-materialize
that referenced
this pull request
Sep 28, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✔️ Ready to be reviewed/merged
Fixes #160, #207