Skip to content
This repository was archived by the owner on Jan 12, 2025. It is now read-only.

sherlock-audit/2024-06-magicsea

Folders and files

NameName
Last commit message
Last commit date

Latest commit

 

History

15 Commits
 
 
 
 
 
 
 
 

Repository files navigation

MagicSea contest details

Q&A

Q: On what chains are the smart contracts going to be deployed?

IotaEVM only


Q: If you are integrating tokens, are you allowing only whitelisted tokens to work with the codebase or any complying with the standard? Are they assumed to have certain properties, e.g. be non-reentrant? Are there any types of weird tokens you want to integrate?

Any type of ERC20 token. Pools are permissionless. So users can open pools even with weird tokens. Issues regarding any weird token will be valid if they have Med/High impact.


Q: Are there any limitations on values set by admins (or other roles) in the codebase, including restrictions on array lengths?

No


Q: Are there any limitations on values set by admins (or other roles) in protocols you integrate with, including restrictions on array lengths?

No


Q: For permissioned functions, please list all checks and requirements that will be made before calling the function.

Only owner modifier


Q: Is the codebase expected to comply with any EIPs? Can there be/are there any deviations from the specification?

N/A


Q: Are there any off-chain mechanisms or off-chain procedures for the protocol (keeper bots, arbitrage bots, etc.)?

We have an keeper for the Voting Epochs


Q: Are there any hardcoded values that you intend to change before (some) deployments?

No


Q: If the codebase is to be deployed on an L2, what should be the behavior of the protocol in case of sequencer issues (if applicable)? Should Sherlock assume that the Sequencer won't misbehave, including going offline?

Yes we are deploying on L2 IOTA - Yes please assume wont misbehave


Q: Should potential issues, like broken assumptions about function behavior, be reported if they could pose risks in future integrations, even if they might not be an issue in the context of the scope? If yes, can you elaborate on properties/invariants that should hold?

No


Q: Please discuss any design choices you made.

N/A


Q: Please list any known issues and explicitly state the acceptable risks for each known issue.

N/A


Q: We will report issues where the core protocol functionality is inaccessible for at least 7 days. Would you like to override this value?

N/A


Q: Please provide links to previous audits (if any).

First audit of this code still in progress


Q: Please list any relevant protocol resources.

https://docs.magicsea.finance/ www.magicsea.finance


Q: Additional audit information.

Could you please focus on the Voting & Bribing System


Audit scope

magicsea-staking @ fb97c8c92f6bca93d1a3184be625712c2fd3c994

About

No description, website, or topics provided.

Resources

Stars

Watchers

Forks

Releases

No releases published

Packages

No packages published

Contributors 4

  •  
  •  
  •  
  •