Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introducing apm-server to elastdocker #85

Merged
merged 2 commits into from
Nov 23, 2022

Conversation

mostafahussein
Copy link
Contributor

@mostafahussein mostafahussein commented Nov 21, 2022

Signed-off-by: (╯°□°)╯︵ uᴉǝssnH ɐɟɐʇsoW [email protected]

What does this implement/fix? Explain your changes.

This PR will do the following:

  • Add apm-server as a running container to the current stack
  • Update kibana.yml with pre-configuration to add apm integration package and create a default policy for it

Does this close any currently open issues?

closes #60

Any relevant logs, error output, etc?

No

Any other comments?

The apm integration configured does not handle settings customization, not sure if it will be possible through API calls

Where has this been tested?

Ubuntu Server 22.04 LTS, verified by the points below:

  • The stack is up and running
  • Elastic APM integration automatically enabled on kibana
  • Custom application using elastic-apm package while passing the CA certificate and secret token to be able to send events to the apm-server

@sherifabdlnaby
Copy link
Owner

@mostafahussein
Impressive! Adding APM Server has been on the TODO list of this project for quite some time! Thank you for your contribution!

Can you please add a section in README to explain how to Connect, Authenticate and Use the APM Server?

@mostafahussein
Copy link
Contributor Author

Thank you @sherifabdlnaby .
Sure, will add a section for APM in the README file

Signed-off-by: (╯°□°)╯︵ uᴉǝssnH ɐɟɐʇsoW <[email protected]>
@mostafahussein
Copy link
Contributor Author

Hi @sherifabdlnaby ,
The README file got updated, please review it and let me know if there are any other modifications required.

@sherifabdlnaby
Copy link
Owner

@mostafahussein Thanks for your contribution! I added a small nitty change to move the APM Section to be before the Monitoring Part.

@sherifabdlnaby sherifabdlnaby merged commit 2e95594 into sherifabdlnaby:main Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add APM Server
2 participants