Fix chrome opacity bug #1942
Merged
Fix chrome opacity bug #1942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -231,6 +231,7 @@ | |||
| height: 100vh; | |||
| opacity: 0.5; | |||
| transition: all 0.3s ease-out, height 0s 0s, opacity 0.3s 0s; | |||
| -webkit-transform: translateZ(0); | |||
There was a problem hiding this comment.
Suggested change
| -webkit-transform: translateZ(0); | |
| transform: translateZ(0); |
@monshan I wonder if we can use just normal transform here? Not sure we need the webkit prefix anymore. Did you test this fix and it fixed the issue?
There was a problem hiding this comment.
@rwwagner90 yes when I did the dev build with this webkit prefix it worked for me, just tried the normal transform though and it also works. I'll re-commit shortly 👍
RobbieTheWagner
approved these changes
Jun 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Shepherd modal shows opaque (black) background at load in Chrome (not observed in other browsers), but returns to 50% opacity at scroll
Findings:
.shepherd-modal-overlay-container.shepherd-modal-is-visiblecss blockSolution:
transformto css selector to force hardware accelerated transition with value of0to have no visual effect other than forcing the hardware transitionCloses #1941