Add stepsContainer option, allowing users to specify rendering target for step elements
#1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobbieTheWagner
approved these changes
Oct 5, 2020
zefj
added a commit
to zefj/shepherd
that referenced
this pull request
Oct 8, 2020
…er` tests (shipshapecode#1176) Co-authored-by: Filip Rec <[email protected]>
zefj
added a commit
to zefj/shepherd
that referenced
this pull request
Oct 8, 2020
…lContainer` tests (shipshapecode#1176)" This reverts commit 2dedf63.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! This PR adds a new option to TourOptions:
stepsContainer, which mimics the behaviour ofmodalContainer. Thanks to this new configuration, it is now possible to specify the render target of step elements, as discussed here.Also added missing types, and some tests for
modalContainerwhile at it.Related:
#1175
#1075 (which is almost the same thing, but my PR is a bit more complete)