fix some bugs #248
Merged
fix some bugs #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
shenweichen
commented
Jun 19, 2022
shenweichen
commented
- Fix model save error when using acc metric model save issue #106
- Fix model error when all feature columns are dense For all dense feature problem, which model should I choose ? #192
解决了 #106 无法保存模型的bug。 原因是lambda表达式无法被pickled。 在`basemodel.py`中的`accuracy`使用了lambda表达式 https://github.com/shenweichen/DeepCTR-Torch/blob/b4d8181e86c2165722fa9331bc16185832596232/deepctr_torch/models/basemodel.py#L492-L494 #106 (comment) 给出了复现方法
2. 完善测试用例，补充无linear part、无dense feature、无sparse feature的用例 3. update doc examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.