-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(changelog): create and add script #53
Conversation
SGTM. I like the idea of doing it manually for the time being. When the manual way gets to be too much of a pain, we can automate it. Just tried this out, and it seems pretty good. The only thing I don't like is that it tries to automatically push the commit, which I wouldn't expect. I'm fine with auto-generating the commit though. If @ariporad disagrees, I'm fine with going with majority opinion on this though. Also, I think we should try to keep PR titles to the commit format @ariporad suggested, since that's what the final commit message gets based off of after the squash-merge (correct me if I'm mistaken). That's only if we're going to continue with that format for commit messages. |
I'm down with manual process, automating only if necessary. Also good with no automatic push, I will remove it. The squash message is editable at merge time. Clicking the merge button switches it to an "edit message" input. |
11a5f1b
to
f973813
Compare
Done. Also, just realized the PR titles will become part of the changelog as well! Updating... |
^ good to know. I feel like github's changing everyday, it's sometimes hard to keep up with it all |
EDIT removed, ignore the rambling... |
LGTM |
Codecov is gagging on this PR for some reason, can't rerun. Going to merge since it touches no functional code. |
Resolves #18.
The changelog and changelog commit in this PR were generated using the script. See commit:
Generate / Update
› npm run changelog ...generating changelog (be patient) ...committing updated changelog Done. You can now 'git push' the updated changelog.
No Changes
When the the changelog is already up to date and the script is run:
Future PRs
Later, this script can be integrated into the CI process. The repo/branch/user can be inferred from CI env vars at that time as well. This just gets it started.