Setup tests #14
Setup tests #14
Conversation
| @@ -18,7 +18,7 @@ const CMD_BLACKLIST = [ | |||
| 'exec', | |||
| ]; | |||
|
|
|||
| const shx = (argv) => { | |||
| export const shx = (argv) => { | |||
There was a problem hiding this comment.
In order to more easily spy/stub default exports, I moved us to named exports. This gives us an import object whose properties we can easily stub. Reference sinonjs/sinon#664.
|
@levithomason: LGTM! But could you rebase off master? (Also, either you or @nfischer needs to comment |
|
@ariporad could we bump lgtm.co down to just one other approval? I think the PR writer implicitly approves of his/her code, so I think one explicit "looks good to me" is enough. I don't want the red-tape to get in the way of development. |
|
Tried this out. Seems to do the job, so LGTM. If there are any issues, I'm sure we can resolve them down the road. |
|
@levithomason could we get this rebased off master? After that, feel free to merge 👍 |
|
Thanks, will try to get this rebased/merged today. |
This PR finishes ava setup and adds a single test as an example. More tests and utlis will be created in separate PRs.