Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature request: --version #111

Closed
nfischer opened this issue Dec 27, 2016 · 1 comment
Closed

feature request: --version #111

nfischer opened this issue Dec 27, 2016 · 1 comment
Labels
feat help wanted low priority

Comments

@nfischer
Copy link
Member

It'd be handy to add --version to the shx binary:

$ shx --version
0.2.2

This is handy when using shx globally (which is the easiest way of reproducing bugs).
@nfischer
Copy link
Member Author

Also, we should probably include the version of the bundled shelljs:

$ shx --version
0.2.2 (using [email protected])

nfischer added a commit that referenced this issue Jun 17, 2018
@nfischer
feat(version): support --version flag
ecb1d38 
This adds support for the `--version` CLI flag. This outputs the version
number for both shx and the bundled version of ShellJS. This adds a test
to strictly assert the output format, so that this can be reliably
parsed if necessary.

This also reorganizes the structure of some test cases (without changing
their logic).

Fixes #111
Test: case: 'supports --version'
@nfischer nfischer mentioned this issue Jun 17, 2018
Merged
nfischer added a commit that referenced this issue Jun 20, 2018
@nfischer
feat(version): support --version flag (#138)
c0d7b8b 
This adds support for the `--version` CLI flag. This outputs the version
number for both shx and the bundled version of ShellJS. This adds a test
to strictly assert the output format, so that this can be reliably
parsed if necessary.

This also reorganizes the structure of some test cases (without changing
their logic).

Lastly, this changes the file modes for 2 files. These were previously
unnecessarily executable.

Fixes #111
Test: case: 'supports --version'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feat help wanted low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nfischer