-
Notifications
You must be signed in to change notification settings - Fork 733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: test Node.js 6, 8, 10 and 11 #908
Conversation
|
But why? They reached their EOL. |
This produces different results in CI and production (lockfiles are not working there).
But it does not seem to be used. |
I'm not aware of a compelling argument to support v6 but not v7. If we support v7, we should probably test it too. Did some digging, and it seems like we switched to |
Not sure I quite understand. Are you objecting to the use of lockfiles in general, or objecting to our install wrapper? |
The first, this is why |
Might consider something like npm/npm#16867 (comment), since lockfiles have so-far caused more trouble than they've been worth. |
Probably, or use Not yet sure what the best solution for everyone is. It's a bit inconsistent across platforms (dev, prod, CI), tools (yarn, npm version) and repository settings (a lockfile might be useful for contributors and CI to build reproducible builds but many big devs like Sindre and others do not use lockfiles for such reasons afaik). Also see sindresorhus/ama#479 |
We can safely use `node_js` on all three supported platforms on Travis CI and remove the obsolete scripts. See #908 (comment)
Test only Node.js 6, 8, 10 (LTS) and stable (11).
https://github.com/nodejs/Release/blob/master/README.md