Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary shell.error checks from common tests #785

Merged
merged 1 commit into from
Oct 14, 2017

Conversation

freitagbr
Copy link
Contributor

Fixes #714

Removes the t.falsy(shell.error()) checks from methods that can't set the error state.

@codecov-io
Copy link

Codecov Report

Merging #785 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #785   +/-   ##
=======================================
  Coverage   95.39%   95.39%           
=======================================
  Files          33       33           
  Lines        1239     1239           
=======================================
  Hits         1182     1182           
  Misses         57       57

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cea0e58...91f8f6d. Read the comment docs.

Copy link
Member

@nfischer nfischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do any common methods set error (aside from common.error)?

@freitagbr
Copy link
Contributor Author

The closure returned from wrap (i.e. any wrapped function) sets state.error to null, but those are covered in other tests obviously.

@freitagbr freitagbr merged commit 32972e0 into master Oct 14, 2017
@freitagbr freitagbr deleted the common-tests-shell-error branch October 14, 2017 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants