Use new child_process.execSync instead of busywaiting #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // CPU usage, though apparently not so much on Windows) | ||
| while (!fs.existsSync(codeFile)) { updateStdout(); fs.writeFileSync(sleepFile, 'a'); } | ||
| while (!fs.existsSync(stdoutFile)) { updateStdout(); fs.writeFileSync(sleepFile, 'a'); } | ||
| if (typeof child.execSync === 'function') { |
|
/cc @Schoonology for another look |
|
LGTM, pending @Schoonology's comments (or not if he's too busy :)) |
|
(Probably goes without saying, but squash it, then...) |
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "shelljs", | |||
| "version": "0.3.0", | |||
| "version": "0.3.1", | |||
There was a problem hiding this comment.
sorry, I do remember you telling me why you chose a patch bump- why was it again? (I'm inclined to go with minor since there's so much at stake 😆)
There was a problem hiding this comment.
Actually I think you're right, we should go with minor. I was originally thinking patch since relatively few people are using node 0.12 or iojs, but minor makes more sense in a semver-ish kinda way. Will update this.
arturadib
added a commit
that referenced
this pull request
Mar 17, 2015
Use new child_process.execSync instead of busywaiting
|
boom |
|
bumped version here 72e34fa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So as to keep CPUs happy.
relevant XKCD on why this may be a bad idea