Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: only allow releases from master branch #8

Merged
merged 1 commit into from
Jan 31, 2018
Merged

feat: only allow releases from master branch #8

merged 1 commit into from
Jan 31, 2018

Conversation

nfischer
Copy link
Member

This change only permits releases from the master branch. Along the same
lines, this change also:

  • Errors-out quickly if the user appears to be outside a git repo
  • Removes the dependency on upstream tracking (assumes you're pushing
    to origin master)

Fixes #2
Fixes #4

@nfischer
feat: only allow releases from master branch
f5d0fcf 
This change only permits releases from the master branch. Along the same
lines, this change also:

 * Errors-out quickly if the user appears to be outside a git repo
 * Removes the dependency on upstream tracking (assumes you're pushing
   to `origin master`)

Fixes #2
Fixes #4
@nfischer nfischer requested a review from freitagbr January 31, 2018 05:14
freitagbr
freitagbr approved these changes Jan 31, 2018
View reviewed changes
Copy link

@freitagbr freitagbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nfischer
Copy link
Member Author

I haven't tested the upstream tracking stuff, but I don't expect issues. I'll double check this works as expected when releasing shx.

@nfischer nfischer merged commit 9cdf8f2 into master Jan 31, 2018
@nfischer nfischer deleted the feat-only-master-branch branch January 31, 2018 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freitagbr freitagbr freitagbr approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nfischer @freitagbr