refactor: change order for publishing #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This completely changes the order of steps we follow for publishing a package. The goal here is to move `npm publish` as close as possible to the beginning so that we can error-out early if it fails (e.g. 2FA errors). At a high level, our new steps are: * npm version (bump version, commit, make tag) * echo npm publish * if successful, push commit & tag * if failed, undo commit & tag In the case of failure, we still provide the same granularity of error output: we check to see if the user is logged in, if they're owner/contributor, etc. In addition, we also provide some error output if the user is outside of a git repo (the usual cause for `npm version` failures). While this refactor is done to enable supporting 2FA, this does not itself provide OTP support. This refactor also adds TODOs for other bugs, which will be resolved in follow-up PRs. Issue #5
|
@freitagbr this is battle tested on the v0.2.0 releases for the plugins:
This finishes way faster now (about 6-7 seconds). I did local tests with an extra patch for |
freitagbr
suggested changes
Jan 30, 2018
| config.silent = false; | ||
| config.fatal = true; | ||
| try { | ||
| // TODO(nfischer): only allow releases from master branch (issue #4) |
There was a problem hiding this comment.
This can be checked easily:
if (exec('git rev-parse --abbrev-ref HEAD').trim() !== 'master') {
echo('');
echo('Releases are permitted only from the master branch.');
exit(1);
}There was a problem hiding this comment.
Let's keep it in a separate PR
freitagbr
approved these changes
Jan 30, 2018
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completely changes the order of steps we follow for publishing a
package. The goal here is to move
npm publishas close as possible tothe beginning so that we can error-out early if it fails (e.g. 2FA
errors).
At a high level, our new steps are:
In the case of failure, we still provide the same granularity of error
output: we check to see if the user is logged in, if they're
owner/contributor, etc. In addition, we also provide some error output
if the user is outside of a git repo (the usual cause for
npm versionfailures).
While this refactor is done to enable supporting 2FA, this does not
itself provide OTP support. This refactor also adds TODOs for other
bugs, which will be resolved in follow-up PRs.
Issue #5