Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not request mongodb-memory-server as peer dependency if it is already a dependency #220

Merged
merged 1 commit into from
Aug 31, 2020
Merged

Do not request mongodb-memory-server as peer dependency if it is already a dependency #220

merged 1 commit into from
Aug 31, 2020

Conversation

danez
Copy link
Contributor

@danez danez commented Aug 31, 2020

I do not think it makes sense to have it in both categories as it is installed anyway.

vladholubiev
vladholubiev approved these changes Aug 31, 2020
View reviewed changes
Copy link
Member

@vladholubiev vladholubiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vladholubiev vladholubiev merged commit c1369b0 into shelfio:master Aug 31, 2020
@vladholubiev
Copy link
Member

@danez published in https://github.com/shelfio/jest-mongodb/releases/tag/v1.2.3

This was referenced May 31, 2021
Closed
Closed
@renovate renovate bot mentioned this pull request Jun 15, 2021
Open
1 task
This was referenced Jul 5, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladholubiev vladholubiev vladholubiev approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danez @vladholubiev