Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复 Table 动态添加行时,横向滚动条可能出现抖动的问题 #821

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

saint3347
Copy link
Collaborator

@saint3347 saint3347 commented Nov 27, 2024

Types of changes

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Others

Changelog

  • 修复 Table 设置了fixedvirtual,但未设置表格高度时,动态添加表格行后横向滚动条出现抖动的问题

Playground id

b3138a05-7e92-4085-a1c0-81334e14af59

Other information

Summary by CodeRabbit

  • 新功能

    • 更新了表格组件的版本至 3.5.2-beta.11,引入了多个bug修复和功能改进。
  • 错误修复

    • 修复了动态行添加时,启用 fixedvirtual 属性的表格出现的水平滚动条抖动问题。
  • 版本更新

    • 版本号从 3.5.2-beta.10 更新至 3.5.2-beta.11

@saint3347 saint3347 added the playground 在 Playground 有示例 label Nov 27, 2024
Copy link

coderabbitai bot commented Nov 27, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

本次更改包括对 package.json 文件的版本号更新,从 "3.5.2-beta.10" 更改为 "3.5.2-beta.11",没有其他依赖、脚本或配置的修改。此外,Scroll 组件中的 useResize 钩子调用进行了调整,新增了一个 timer 参数,值为 0,可能影响组件对大小变化的响应。最后,Table 组件的变更日志也进行了更新,记录了新版本的发布及其修复的相关问题。

Changes

文件路径 更改摘要
package.json 版本更新:"version": "3.5.2-beta.10""version": "3.5.2-beta.11"
packages/base/src/virtual-scroll/scroll.tsx 修改 Scroll 组件中的 useResize 钩子调用,新增 timer 参数,值为 0
packages/shineout/src/table/__doc__/changelog.cn.md 更新 Table 组件的变更日志,记录版本 3.5.2-beta.11 的发布及修复的相关问题。

Possibly related PRs

Suggested labels

bug

Poem

在兔子洞里欢快跳,
版本更新真是好!
Scroll 组件更灵活,
表格修复不再抖。
新的日志记录明,
兔子欢呼声声鸣! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@saint3347 saint3347 merged commit cbf4b29 into main Nov 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
playground 在 Playground 有示例
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant