Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复 Cascader非虚拟列表情况下搜索内容溢出列表的问题,搜索结果列表支持虚拟列表 #798

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

KMS-Bismarck
Copy link
Collaborator

@KMS-Bismarck KMS-Bismarck commented Nov 13, 2024

Types of changes

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Others

Changelog

  • 修复 Cascader 非虚拟列表情况下搜索内容溢出列表的问题
  • Cascader 单选模式下搜索结果列表支持虚拟列表

Other information

Summary by CodeRabbit

  • 新功能

    • 更新了 Cascader 组件,增加了 keygenheightsizevirtual 属性,提升了组件的灵活性。
    • 支持虚拟列表的搜索结果显示,改善了单选模式下的用户体验。
  • 错误修复

    • 修复了在非虚拟列表模式下搜索内容溢出的问题。
  • 版本更新

    • 版本号更新至 3.5.1-beta.4,反映了小幅改进和错误修复。

Copy link

coderabbitai bot commented Nov 13, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

本次更改涉及多个文件,主要更新了 Cascader 组件及其相关接口,增强了组件的灵活性和响应能力。package.json 文件的版本号从 3.5.1-beta.3 更新为 3.5.1-beta.4,反映了小幅更新。Cascader 组件新增了多个属性,如 keygenheightsizevirtual,并对样式和渲染逻辑进行了调整,以支持虚拟列表和更好的错误处理。此外,更新了相关的类型定义和样式文件,确保新功能的兼容性。

Changes

文件路径 更改摘要
package.json 版本号更新:"3.5.1-beta.3""3.5.1-beta.4"
packages/base/src/cascader/cascader.tsx 新增属性 keygenheightsizevirtual,更新 renderFilterList 方法,改进状态处理和错误处理。
packages/base/src/cascader/cascader.type.ts 新增属性 virtual: stringvirtual?: boolean 到接口 CascaderClassesCascaderProps
packages/base/src/cascader/filter-list.tsx 新增属性 keygenvirtualheightsize,更新渲染逻辑以支持虚拟列表。
packages/base/src/cascader/filter-list.type.ts 更新 FilterListProps 接口,新增属性 virtualkeygensizeheight
packages/shineout-style/src/cascader/cascader.ts 新增样式属性 virtual,更新 filterList 样式以管理溢出行为。
packages/shineout/src/cascader/__doc__/changelog.cn.md 更新变更日志,记录版本 3.5.1-beta.4 的新特性和修复。

Possibly related PRs

Suggested labels

bug

兔子欢跳庆新变,
组件更新乐无边。
虚拟列表新功能,
样式流畅如春泉。
错误处理更严谨,
快乐编程乐无眠! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@KMS-Bismarck KMS-Bismarck merged commit 17c8c38 into main Nov 13, 2024
@KMS-Bismarck KMS-Bismarck deleted the fix-bug-cascader-list branch November 13, 2024 09:02
KMS-Bismarck added a commit that referenced this pull request Nov 15, 2024
* fix: 修复 `Cascader` 非虚拟列表情况下搜索内容溢出列表的问题

* feat: `Cascader` 单选模式下搜索结果列表支持虚拟列表

---------

Co-authored-by: 颜宇浩 <[email protected]>
KMS-Bismarck added a commit that referenced this pull request Nov 20, 2024
* fix: 修复 `Cascader` 非虚拟列表情况下搜索内容溢出列表的问题

* feat: `Cascader` 单选模式下搜索结果列表支持虚拟列表

---------

Co-authored-by: 颜宇浩 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant