Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Input.Number 输入框删完最后一个数字时不触发onChange的问题(此时返回null或undefined) #780

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

saint3347
Copy link
Collaborator

@saint3347 saint3347 commented Nov 4, 2024

Types of changes

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Others

Changelog

  • Input.Number 输入框删完最后一个数字时不触发onChange的问题(此时返回null或undefined)

Summary by CodeRabbit

  • 新功能

    • 更新了 Input.Number 组件的输入处理逻辑,支持在输入框清空时返回 nullundefined,具体取决于 allowNull 属性。
    • 修改了 App 组件以增强 Input.Number 组件的功能,添加了输入变化时的控制台日志记录功能。
  • 错误修复

    • 修复了 Input.Number 组件在删除最后一位数字时未触发 onChange 事件的问题。
  • 文档

    • 更新了 shineout 包的变更日志,记录了版本 3.4.6-beta.3 的更新内容。

Copy link

coderabbitai bot commented Nov 4, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

此拉取请求包含对项目版本号的更新以及对输入组件处理逻辑的改进。package.json 文件中的版本号从 "3.4.6-beta.2" 更新为 "3.4.6-beta.3"。同时,use-input-number.ts 文件中的 useNumberFormat 钩子被修改,以便在输入值为空字符串时根据 allowNull 属性处理输入值。最后,更新了 shineout 包的变更日志,并在示例文件中增强了对输入变化的反馈。

Changes

文件路径 变更摘要
package.json 更新版本号:"version": "3.4.6-beta.2""version": "3.4.6-beta.3"
packages/hooks/src/components/use-input/use-input-number.ts 修改 useNumberFormat 钩子,添加条件检查以处理空字符串输入,更新 onBlur 逻辑。
packages/shineout/src/input/__doc__/changelog.cn.md 添加版本 3.4.6-beta.3 的变更日志,记录 Input.Number 组件的 bug 修复。
packages/shineout/src/input/__example__/03-number-1.tsx 修改 App 组件,增加 onChange 事件处理器以记录输入值变化。

Possibly related PRs

  • chore: release 3.3.6 #631: 此PR将 package.json 中的版本号从 "3.3.6-beta.6" 更新为 "3.3.6",与主PR中的版本增量相似。
  • chore: release 3.4.2 #690: 此PR将 package.json 中的版本号从 "3.3.3-beta.7" 更新为 "3.3.3",反映出与主PR相似的版本更改。
  • fix: release-3.4.2 #696: 此PR将 package.json 中的版本号从 "3.4.2-beta.7" 更新为 "3.4.2",表明从 beta 版本过渡到稳定版本,与主PR中的版本更改类似。
  • chore: changlog of 3.4.3 #715: 此PR将 package.json 中的版本号从 "3.4.3-beta.11" 更新为 "3.4.3",与主PR中观察到的版本增量一致。
  • chore: release 3.4.5-beta.6 #768: 此PR将 package.json 中的版本号从 "3.4.5-beta.5" 更新为 "3.4.5-beta.6",显示出与主PR中的变更相似的小版本增量。

Suggested labels

bug

🐇 版本更新如春风,
输入逻辑更灵动。
清空输入无烦恼,
日志记录助人知。
兔子欢跳庆新生,
代码世界更美好! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@saint3347 saint3347 merged commit 2cb54c4 into main Nov 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant