Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build #722

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Fix build #722

merged 2 commits into from
Oct 15, 2024

Conversation

saint3347
Copy link
Collaborator

@saint3347 saint3347 commented Oct 15, 2024

Types of changes

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Others

Summary by CodeRabbit

  • 新特性

    • Form 组件的 formRef 设置方法现在支持嵌套对象值。
  • 增强

    • 版本分类调整,原新特性现标记为增强。
  • 错误修复

    • 修复了多个版本中的验证问题,确保 name 字段为数组时的正常工作。
    • 解决了重置值时触发多个 onChange 事件的问题。
    • 改进了当 name 重复时的受控行为。
    • 解决了当 value 设置为 null 时的状态更新问题。
    • 修复了 Form.FieldSet 中值更新的问题。
  • 样式调整

    • Form.Item 进行了样式调整,包括内边距和行内模式下的宽度调整。

Copy link

coderabbitai bot commented Oct 15, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

此次更改主要集中在两个文件中。tabs.ts文件简化了导入语句,并标准化了tabsStyle对象中的过渡属性,删除了对CommonToken的导入,改为仅导入Token。同时,headerScrollBar的过渡属性从使用CommonToken['Animation-duration-2']更新为固定时长.2s。在changelog.cn.md文件中,版本号从3.5.0-beta.1更改为3.4.4-beta.1,并更新了日期,同时对Form组件的增强功能和多个错误修复进行了记录。

Changes

文件路径 更改摘要
packages/shineout-style/src/tabs/tabs.ts - 导入语句修改:import Token, {CommonToken} from '@sheinx/theme';import Token from '@sheinx/theme';
- 过渡属性更新:headerScrollBar的过渡属性从CommonToken['Animation-duration-2']改为.2s
packages/shineout/src/form/doc/changelog.cn.md - 版本更新:3.5.0-beta.13.4.4-beta.1
- 更新日期:2024-10-112024-10-15
- 增强功能:formRef设置方法支持嵌套对象值
- 记录多个错误修复和样式调整。

Possibly related PRs

🐰 在兔子洞里,样式更清晰,
导入简化,过渡更流畅,
版本更新,功能增强,
错误修复,用户更欢畅,
兔子欢跳,庆祝这变化!
🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@saint3347 saint3347 merged commit 7c8d218 into main Oct 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant