Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Table 组件 onScroll 事件新增 top 参数 #658

Merged
merged 3 commits into from
Sep 19, 2024
Merged

feat: Table 组件 onScroll 事件新增 top 参数 #658

merged 3 commits into from
Sep 19, 2024

Conversation

KMS-Bismarck
Copy link
Collaborator

Types of changes

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Others

Changelog

  • Table 组件 onScroll 事件新增 top 参数

Other information

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Sep 10, 2024 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai generate interesting stats about this repository and render them as a table.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@KMS-Bismarck KMS-Bismarck merged commit 99b0805 into dev-3.4.0 Sep 19, 2024
1 check passed
@KMS-Bismarck KMS-Bismarck deleted the feat-table-scroll branch September 19, 2024 02:36
KMS-Bismarck added a commit that referenced this pull request Sep 19, 2024
@KMS-Bismarck @saint3347 @leehaoChen
feat: 3.4.0 (#677)
d6cae6a 
🐞 BugFix

- 修复 `Carousel` 组件点击箭头切换后，鼠标悬停时没有禁用切换的现象 (#674)
- 修复 `Rate` 组件在 Safari 浏览器下对齐样式异常的问题(#670)
- 修复 `TableRef` 的 `scrollToIndex` 的回调方法不生效问题 (#651)
- 修复 `Tabs` 组件的 Tabs.Panel 是异常动态长度时，需要 resize 页面才会出现左右的滚动箭头 (#668)
- 修复 `TreeSelect` 组件 `filterDelay` 属性失效的问题 (#672)
- 修复 `Modal` 组件使用方法调用方式时，点击确定或取消按钮没有关闭动画 (#675)
- 修复 `Modal` 组件下存在多个 Form 组件时，Modal.Submit 提交无效的问题 (#625)


🆕 Feature

- 新增 `Link` 组件
- 新增 `Badge` 组件
- `Datepicker` 新增 `needConfirm` 属性: 是否开启手动确认按钮，开启后只有点击确认按钮才会提交选择的值 (#650)
- `Datepicker` 新增 `clearToUndefined`，点击清除后返回 undefined (#644)
- `Dropdown` 组件新增 `zIndex` 属性 (#660)
- `Menu` 组件新增父节点激活状态下的文字颜色 token (#659)
- `Select` 组件支持动态虚拟列表行高(#646)
- `Select` 组件新增 `onLoadMore` 属性，支持滚动加载 (#610)
- `Select` 组件新增 `threshold` 属性，支持设置滚动加载阈值 (#610)
- `Select` 组件新增 `trigger` 属性，支持更改展开下拉面板的触发方式 (#610)
- `Table` 组件新增属性 `showTopScrollbar`，开启顶部滚动条 (#671)
- `Table` 组件 `onScroll` 事件新增 top 参数 (#658)
- `Table` 组件 `Ref` 支持 `getRenderIndexByData` 方法，用于获取指定数据在渲染列表中的索引
- `Textarea` 组件 `info` 属性新增配置模式，支持配置定位 (#676)
- `Tree` 组件新增 `setActive` 属性，与active组成高亮的受控功能 (#665)


💎 Enhancement

- 优化 `Select` 组件在同时使用 `emptyText` 和 `renderOptionList` 时的渲染顺序 (#627)
- 优化 `Table` 初始化加载性能 (#673)


---------

Co-authored-by: 翟胜佳 <[email protected]>
Co-authored-by: 颜宇浩 <[email protected]>
Co-authored-by: saint <[email protected]>
Co-authored-by: 利浩 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@KMS-Bismarck