Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec tweaks, and add select_continue #39

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Bentheburrito
Copy link

@Bentheburrito Bentheburrito commented Jan 4, 2025

Hello! Thanks for this lib, it's been very helpful in one of my projects as I learn Mnesia.

This PR fixes a couple of spec discrepancies dialyzer highlighted, adds support for :coerce in read/3, and adds Query.select_continue.

I hope you don't mind, I also added a .formatter.exs and formatted the project (a4214bc). Reviewing by these commits (with with actual functional changes) will be easier:

  • 591fe4e spec changes, support :coerce in read
  • bb108c2 adds select_continue

@sheharyarn
Copy link
Owner

sheharyarn commented Jan 14, 2025

Thank you for the PR!

This project was started before the Elixir formatter was created, and follows its own unique style-guide (which predates formatter). I do plan on updating the code formatting and style to use the modern formatter but that requires a bit of work from me before I'm ready to do that.

Would you be kind enough to update your PR to only include the code changes, spec tweaks, etc. without the formatting?

Thank you again!

@Bentheburrito
Copy link
Author

That makes sense - I reverted the formatting changes in the last commit. Let me know if anything else should be changed!

@Bentheburrito Bentheburrito changed the title add formatter, spec tweaks, and add select_continue spec tweaks, and add select_continue Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants