cloth-config dependency support #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattSturgeon
commented
May 9, 2023
common/src/main/java/me/shedaniel/clothconfig2/api/ValueHolder.java
Outdated
Show resolved
Hide resolved
MattSturgeon
commented
May 9, 2023
|
@shedaniel do you think you'll get time to review this soon? I'm open to feedback and discussing the overall design if you have a different approach in mind. |
|
Thank you for this PR and sorry that I have completely forgotten about this, please continue to notify me if I forget in the future. |
shedaniel
requested changes
Jun 26, 2023
common/src/main/java/me/shedaniel/clothconfig2/gui/entries/TooltipListEntry.java
Outdated
Show resolved
Hide resolved
common/src/main/java/me/shedaniel/clothconfig2/gui/entries/TooltipListEntry.java
Outdated
Show resolved
Hide resolved
common/src/main/java/me/shedaniel/clothconfig2/gui/widget/DynamicEntryListWidget.java
Outdated
Show resolved
Hide resolved
common/src/main/java/me/shedaniel/clothconfig2/gui/widget/DynamicEntryListWidget.java
Outdated
Show resolved
Hide resolved
common/src/main/java/me/shedaniel/clothconfig2/gui/widget/DynamicEntryListWidget.java
Outdated
Show resolved
Hide resolved
shedaniel
requested changes
Jun 26, 2023
common/src/main/java/me/shedaniel/clothconfig2/api/AbstractConfigEntry.java
Outdated
Show resolved
Hide resolved
common/src/main/java/me/shedaniel/clothconfig2/api/AbstractConfigEntry.java
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
shedaniel
requested changes
Jul 3, 2023
common/src/main/java/me/shedaniel/clothconfig2/gui/widget/DynamicEntryListWidget.java
Show resolved
Hide resolved
common/src/main/java/me/shedaniel/clothconfig2/gui/widget/DynamicEntryListWidget.java
Outdated
Show resolved
Hide resolved
|
Fixed your latest points. Also found and fixed a bug where a hidden boolean toggle entry was still handling click events: aa22d5e |
shedaniel
requested changes
Jul 3, 2023
common/src/main/java/me/shedaniel/clothconfig2/api/DisableableWidget.java
Outdated
Show resolved
Hide resolved
Allows users to define dependency `Requirement`s as lambda functions, or generate them via factory methods. A standard requirement controls whether a Config Entry is "enabled" or "disabled". When "disabled" the Config Entry is greyed-out and cannot be interacted with. A "display" requirement controls whether a Config Entry appears _at all_ in the GUI. It's still technically present, but won't be rendered or take up any space in the list GUI. A hidden Config Entry is also disabled automatically.
MattSturgeon
force-pushed
the
dependencies-v2
branch
from
85d1cdb to
8eb1416
Compare
MattSturgeon
changed the title
shedaniel
approved these changes
Jul 3, 2023
|
Great, thanks for all your help and guidance. 🎉 Would you like the PR to target a different branch or stick with Enjoy your trip! |
shedaniel
added a commit
that referenced
this pull request
Jul 9, 2023
* Enable/Display config entries using dependencies Allows users to define dependency `Requirement`s as lambda functions, or generate them via factory methods. A standard requirement controls whether a Config Entry is "enabled" or "disabled". When "disabled" the Config Entry is greyed-out and cannot be interacted with. A "display" requirement controls whether a Config Entry appears _at all_ in the GUI. It's still technically present, but won't be rendered or take up any space in the list GUI. A hidden Config Entry is also disabled automatically. * Apply license headers --------- Co-authored-by: shedaniel <[email protected]>
shedaniel
added a commit
that referenced
this pull request
Jul 9, 2023
* Enable/Display config entries using dependencies Allows users to define dependency `Requirement`s as lambda functions, or generate them via factory methods. A standard requirement controls whether a Config Entry is "enabled" or "disabled". When "disabled" the Config Entry is greyed-out and cannot be interacted with. A "display" requirement controls whether a Config Entry appears _at all_ in the GUI. It's still technically present, but won't be rendered or take up any space in the list GUI. A hidden Config Entry is also disabled automatically. * Apply license headers --------- Co-authored-by: shedaniel <[email protected]>
MattSturgeon
added a commit
to MattSturgeon/cloth-config
that referenced
this pull request
Jul 21, 2023
Follow up from shedaniel#204, adds annotation based dependency support to autoconfig.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from my initial draft PR #195, here's a subset of the changes focused on adding dependency support to cloth config.
I identified the main cause of complexity in the draft PR was auto-generating human readable descriptions of potentially complex dependencies. In hindsight, the result isn't worth the added complexity, instead it is recommended that users write their own dependency descriptions in tooltips or labels.
This PR does add a simple "Dependencies not met" line to the tooltip when
isEnabled()isfalse. This could be removed/reformatted/reworded depending on your preference.Currently, theimplementedDependencymay be checked multiple times per frame. If this proves performance intenseive, it may make sense to instead check once-per-tick on the main thread and store the result in anAtomicBooleanto reference from the render thread.I plan to add an implementation for autoconfig in a follow up PR, based on what I have currently in the initial draft, but ideally this should be merged first - or at least the design agreed upon.
Fixes #26