Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GUI - support multiple tree selections #600

Closed
shawnlaffan opened this issue May 31, 2016 · 2 comments
Closed

GUI - support multiple tree selections #600

shawnlaffan opened this issue May 31, 2016 · 2 comments
Assignees
@shawnlaffan
Labels
enhancement GUI
Milestone
Release_2.0

Comments

@shawnlaffan
Copy link
Owner

It would be useful for users to be able to click on branches in the trees to colour the cells, but where each click does not override the preceding colouring.

This will probably need a different selection mode, with the option to choose colours as the clicking progresses.
shawnlaffan added a commit that referenced this issue Sep 6, 2016
@shawnlaffan
Add some treenode utility functions
9e47d00 
Updates #600
shawnlaffan added a commit that referenced this issue Sep 6, 2016
@shawnlaffan
refactor and cleanup
c89c4c0 
Some subs weren't being used, some of which had never been used
and which had equivalents that were in use.

Also add option for sequential colouring.  Does nothing
at the moment, hence the name.

Updates #600
shawnlaffan added a commit that referenced this issue Sep 6, 2016
@shawnlaffan
initial working version of the multi-select process
161add8 
Internal names need to change, and the colours need to be
incremented to reduce user interaction (if not desired).

Also does not clean up after itself properly yet.

Updates #600
shawnlaffan added a commit that referenced this issue Sep 6, 2016
@shawnlaffan
show/hide the cluster colour and number selectors
70eb62c 
Multi-select ignores the cluster numbers,
and normal select ignores the colour.

Updates #600
shawnlaffan added a commit that referenced this issue Sep 6, 2016
@shawnlaffan
add method to increment the multi-select colour
4a8c4d7 
Also add methods to get the colour palettes as Gtk2::Gdk::Color objects.

The increment process needs some thought yet,
as it currently resets to red if a colour from
outside the palette is used.

This will be simplified once we keep track of which nodes are which colour.

Updates #600
shawnlaffan added a commit that referenced this issue Sep 6, 2016
@shawnlaffan
refactor the dendrogram colour callbacks
426f649 
This simplifies the code below.

Updates #600
shawnlaffan added a commit that referenced this issue Sep 6, 2016
@shawnlaffan
remove dependency on Tie::RefHash
23c0636 
Now we cache by node name, with hash values being the refs.

Updates #600
shawnlaffan added a commit that referenced this issue Sep 6, 2016
@shawnlaffan
avoid croaking as the labels tab does not use multi-select
f4887d2 
Also increment the colour when we switch and something
has been selected already.

Updates #600
shawnlaffan added a commit that referenced this issue Sep 6, 2016
@shawnlaffan
Don't clear colours if we are in multi-select mode when background is…
d03e1ac 
… clicked

Updates #600
shawnlaffan added a commit that referenced this issue Sep 6, 2016
@shawnlaffan
Add capacity to reset branch colours under multi-select
d9027f2 
Uses a toggle button to do so.

Updates #600
shawnlaffan added a commit that referenced this issue Sep 8, 2016
@shawnlaffan
use a method to test if we are in multi-select mode
ff73ef6 
Updates #600
shawnlaffan added a commit that referenced this issue Sep 8, 2016
@shawnlaffan
reinstate or clear the multi-select colours when changing plot modes
b71100f 
Updates #600
shawnlaffan added a commit that referenced this issue Sep 8, 2016
@shawnlaffan
Store the multi-select colour cache on the tree object
e9e99d8 
This allows us to reload from saved files.

Updates #600
shawnlaffan added a commit that referenced this issue Sep 9, 2016
@shawnlaffan
don't colour all nodes when switching to multiselect mode
eb105ac 
Still has debugging statements that will be
cleaned up in the next commit.

Updates #600
shawnlaffan added a commit that referenced this issue Sep 9, 2016
@shawnlaffan
we now save the multiselect clear events
6bca07b 
This is at the cost of yet more flags.
This package is in much need of a refactor
and simplification.

Updates #600
shawnlaffan added a commit that referenced this issue Sep 9, 2016
@shawnlaffan
don't set a flag in this sub
ae9f925 
Updates #600
shawnlaffan added a commit that referenced this issue Sep 9, 2016
@shawnlaffan
Hide the slider bar when in multiselect mode
2a0829c 
Updates #600
shawnlaffan added a commit that referenced this issue Sep 9, 2016
@shawnlaffan
Set the cursor for clear mode to match the selector
11a7395 
This is shown when hovering over a branch
and makes it more obvious that clearing will
occur on click.

Updates #600
shawnlaffan added a commit that referenced this issue Sep 9, 2016
@shawnlaffan
Avoid storing sequential multiselect duplicates
a25ec51 
The system double triggers for some reason
that needs to be looked into.

Updates #600
shawnlaffan added a commit that referenced this issue Sep 12, 2016
@shawnlaffan
Shift the multiselect replay code into its own sub
c1031e6 
This is preparatory to undo/redo,
as well as being good hygiene.

Updates #600
shawnlaffan added a commit that referenced this issue Sep 12, 2016
@shawnlaffan
Add undo capability to the multiselect interface
4522b1c 
We also store the undone stack for a later redo option.

Updates #600
shawnlaffan added a commit that referenced this issue Sep 12, 2016
@shawnlaffan
Implement redo for multiselect mode
1f16667 
Currently we reset the redo stack as soon as a branch
is coloured as multiple redo branches would be a nightmare.

Updates #600
@shawnlaffan shawnlaffan self-assigned this Sep 12, 2016
@shawnlaffan shawnlaffan added this to the Release_2.0 milestone Sep 12, 2016
shawnlaffan added a commit that referenced this issue Sep 12, 2016
@shawnlaffan
Set project dirty state when multiselect mode is used
c02dd40 
This was the user is prompted to save the changes,
and thus the selections.

Updates #600
shawnlaffan added a commit that referenced this issue Sep 12, 2016
@shawnlaffan
add a get_parent_tab method
707eff6 
Updates #600
shawnlaffan added a commit that referenced this issue Sep 12, 2016
@shawnlaffan
Hide the graph slider in multiselect mode
5aba21a 
Updates #600
shawnlaffan added a commit that referenced this issue Sep 12, 2016
@shawnlaffan
Use "multiselect", not "sequential", in the code
fad2521 
Sequential was a place holder.

Updates #600
@shawnlaffan shawnlaffan mentioned this issue Sep 12, 2016
Open
@shawnlaffan
Copy link
Owner Author

shawnlaffan commented Sep 13, 2016 •
edited
Loading

To do:

  • Optionally turn off autoincrement. (Done in 94b0984 )

shawnlaffan added a commit that referenced this issue Sep 13, 2016
@shawnlaffan
Add toggle to control colour autoincrement
94b0984 
Default is on.

Updates #600
shawnlaffan added a commit that referenced this issue Sep 13, 2016
@shawnlaffan
replace more "sequential" names with "multiselect"
2678655 
Updates #600
@shawnlaffan
Copy link
Owner Author

Mark as fixed.
Further changes can be listed under their own issues and cross-reference this one.

@shawnlaffan shawnlaffan mentioned this issue Oct 6, 2016
Closed
@shawnlaffan shawnlaffan mentioned this issue Dec 2, 2016
Closed
8 tasks
@shawnlaffan shawnlaffan mentioned this issue Mar 3, 2017
Closed
@shawnlaffan shawnlaffan mentioned this issue Feb 28, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawnlaffan shawnlaffan

Labels
enhancement GUI
Projects
None yet
Milestone
Release_2.0
Development

No branches or pull requests
1 participant
@shawnlaffan