textfile: fix duplicate metrics error (prometheus#738)

The textfile gatherer should only be added to gatherer list once. Signed-off-by: Li Wei <[email protected]>
shatteredsilicon · Apr 9, 2024 · 091813d · 091813d
1 parent e1a7e93
commit 091813d
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/collector/textfile.go b/collector/textfile.go
@@ -23,6 +23,7 @@ import (
 	"path/filepath"
 	"sort"
 	"strings"
+	"sync"
 	"time"
 
 	"github.com/golang/protobuf/proto"
@@ -35,6 +36,7 @@ import (
 
 var (
 	textFileDirectory = kingpin.Flag("collector.textfile.directory", "Directory to read text files with metrics from.").Default("").String()
+	textFileAddOnce   sync.Once
 )
 
 type textFileCollector struct {
@@ -57,10 +59,12 @@ func NewTextFileCollector() (Collector, error) {
 		// the flag is not passed.
 		log.Infof("No directory specified, see --collector.textfile.directory")
 	} else {
-		prometheus.DefaultGatherer = prometheus.Gatherers{
-			prometheus.DefaultGatherer,
-			prometheus.GathererFunc(func() ([]*dto.MetricFamily, error) { return c.parseTextFiles(), nil }),
-		}
+		textFileAddOnce.Do(func() {
+			prometheus.DefaultGatherer = prometheus.Gatherers{
+				prometheus.DefaultGatherer,
+				prometheus.GathererFunc(func() ([]*dto.MetricFamily, error) { return c.parseTextFiles(), nil }),
+			}
+		})
 	}
 
 	return c, nil