Fix regression introduced in pinterest#1129

- Used imports state has to be reset per-file
shashachu · Aug 6, 2021 · 6db3932 · 6db3932
1 parent 0bcfbfd
commit 6db3932
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 0 deletions.
diff --git a/...set-standard/src/main/kotlin/com/pinterest/ktlint/ruleset/standard/NoUnusedImportsRule.kt b/...set-standard/src/main/kotlin/com/pinterest/ktlint/ruleset/standard/NoUnusedImportsRule.kt
@@ -86,6 +86,7 @@ class NoUnusedImportsRule : Rule("no-unused-imports") {
             ref.add(Reference("*", false))
             parentExpressions.clear()
             imports.clear()
+            usedImportPaths.clear()
             node.visit { vnode ->
                 val psi = vnode.psi
                 val type = vnode.elementType

diff --git a/...standard/src/test/kotlin/com/pinterest/ktlint/ruleset/standard/NoUnusedImportsRuleTest.kt b/...standard/src/test/kotlin/com/pinterest/ktlint/ruleset/standard/NoUnusedImportsRuleTest.kt
@@ -729,4 +729,34 @@ class NoUnusedImportsRuleTest {
             )
         ).isEmpty()
     }
+
+    @Test
+    fun `repeated invocations on the same rule instance should work`() {
+        val rule = NoUnusedImportsRule()
+        assertThat(
+            rule.lint(
+                """
+                import foo.bar
+
+                fun main() {
+                    bar()
+                }
+                """.trimIndent()
+            )
+        ).isEmpty()
+
+        assertThat(
+            rule.lint(
+                """
+                import foo.bar
+                import foo.baz
+
+                fun main() {
+                    bar()
+                    baz()
+                }
+                """.trimIndent()
+            )
+        ).isEmpty()
+    }
 }