Desktop file creation #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharkwouter
approved these changes
Dec 26, 2024
|
Thanks! This looks good! For the other PR I'll still need some time to review it, but I have seen it and I really appreciate the work. |
|
Sure, take all the time you need. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While testing, I discovered that I've introduced a new error with my previous PR #624:
The change in how the value for the 'Exec' key in .desktop files is generated.
I assumed that Exec uses quoting rules identical to shells. However, it does not. Only " can be used for quotes and there are less special characters. shlex.join quotes differently, it uses single quotes ' exclusively which is not compatible with how the Exec key is supposed to be quoted.
I restored the get_exec_line method in installer.py which i previously deleted, and enhanced it instead to conform to the quoting rules as described in The Exec Key.
Sorry about this oversight on my part.
Checklist