Wine: Installer language #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reworked and enhanced lang_install: 1. now uses 2 different strategies for language detection 2. renamed to match_game_lang_to_installer to better match actual purpose 3. slightly change _exe_cmd again to make it consume everything of Popen without readlines() calls after actual execution loop
GB609
force-pushed
the
feature/wine_lang_install
branch
from
00759e4 to
e4f2599
Compare
sharkwouter
requested changes
Jan 5, 2025
* sleep before poll in _exe_cmd * change how mocks in tests for match_lang_to_installer are set up
sharkwouter
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a follow up on #624. Here, I'm doing the rest of the clean up and code rework related to innoextract.
Innoextract will now only be used for language detection during installation and the respective method has been reworked to have a clearer return value and more robust error handling.
I've also completely remove the old extract_by_innoextract install method since it is not used anymore.
Moreover, the new method match_game_lang_to_installer writes the output of innoextract into a log file (game.install_dir/minigalaxy_setup_languages.log).
With that, installing windows games now produces 3 small log files we can use for error reports and analysis:
Coupled with everything that now also goes into minigalaxies default logging, there should be a lot of information to trace back errors on installations.
Checklist